Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented FtpSource based on FluentFtp library #126

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PurpleGray
Copy link

Hello, in my project I've been using your library, but my requirement was to update from ftp. So I've added new type of source, so created this pull request. May be it can be useful for someone.

@synhershko
Copy link
Owner

Great, thanks! Any reason you are using FluentFTP and not the CLR's classes ? We would like to keep this library without dependencies

See https://msdn.microsoft.com/en-us/library/system.net.ftpwebrequest.aspx

@PurpleGray
Copy link
Author

Ohh, you're right, I've been thinking about it, but just for time economy decided to use FluentFTP. I will rewrite it to CLR :)

@PurpleGray PurpleGray force-pushed the ftp_source branch 2 times, most recently from 150fdb3 to acd721f Compare August 10, 2018 11:37
@PurpleGray
Copy link
Author

Ok, moved from FluentFTP to CLR

@synhershko
Copy link
Owner

Thanks, looks good! Any chance you can add tests for this new Source class?

@PurpleGray
Copy link
Author

Yep, I'll do it in this week

@PurpleGray
Copy link
Author

PurpleGray commented Aug 17, 2018

Hm, but how can I test ftp source?
I found only approach like this: https://dougrathbone.com/blog/2012/09/26/integration-testing-ftp-connections-in-net
Is it acceptable way to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants